Repository navigation
Conversation
`sqllite` This protects against a UAF from an execute and clear in two thrads in a FT build and closing on `execute` which can execute arbituary python code before the execution (impacting GIL build too).
self->connection->statement_cache inself->connection->statement_cache in sqlite
self->connection->statement_cache in sqliteself->connection->statement_cache in sqlite3
johng
commented
Nov 19, 2026
| size_t nargsf = 1 | PY_VECTORCALL_ARGUMENTS_OFFSET; | ||
| return PyObject_Vectorcall(cache, args + 1, nargsf, NULL); | ||
| PyObject *stmt = PyObject_Vectorcall(cache, args + 1, nargsf, NULL); | ||
| Py_DECREF(cache); |
Contributor
Author
There was a problem hiding this comment.
Think we need to re-check the connection here is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This protects against a UAF from an
executeandclearin two threads in a FT build and closing onexecutewhich can execute arbituary python code before the execution (impacting GIL build too).